-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows: Delayed Message Boxes Fix. #1769
Conversation
I ran ahead and tried your changes and it seems this fixes the problem on my machine (latest Win10). |
CI now fails on docs after I updated the changelog... Seems to be unrelated though: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for looking into this!
Message boxes did not appear when opening them. The sound did play but they never were made visible unless the system triggers a redraw (for example when you press
alt
). The solution to this is to add the defaultWM_PAINT
behavior back in. (DefWindowProc
does this if you don't overrideWM_PAINT
)(This issue appeard in #1615)
cargo fmt
has been run on this branchcargo doc
builds successfullyCHANGELOG.md
if knowledge of this change could be valuable to users