Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect ReceivedCharacter events on macOS #1453

Closed
chrisduerr opened this issue Feb 11, 2020 · 0 comments · Fixed by #1501
Closed

Incorrect ReceivedCharacter events on macOS #1453

chrisduerr opened this issue Feb 11, 2020 · 0 comments · Fixed by #1501
Labels
B - bug Dang, that shouldn't have happened C - needs investigation Issue must be confirmed and researched DS - macos

Comments

@chrisduerr
Copy link
Contributor

This has been reported downstream in alacritty/alacritty#3323 and is a regression caused by 9daa073.

It seems like the fix for certain keyboard shortcuts not triggering ReceivedCharacter events was a bit over-eager and resulted in existing events that were working to suddenly send incorrect characters.

So the combination of shift+ctrl+6 now sends just 6 as character, instead of the desired \u{1e}.
@chrisduerr chrisduerr mentioned this issue Feb 11, 2020
Closed
@goddessfreya goddessfreya added DS - macos C - needs investigation Issue must be confirmed and researched B - bug Dang, that shouldn't have happened labels Feb 14, 2020
kchibisov added a commit to kchibisov/winit that referenced this issue Mar 7, 2020
@kchibisov
Revert "on MacOS, Fix not sending ReceivedCharacter event for some ke…
8b47e6e 
…y combination (rust-windowing#1347)"

This reverts commit 9daa073.

This commit introduced other bug rust-windowing#1453 with likely much more common bindings,
so reverting it for now.

Fixes rust-windowing#1453.
@kchibisov kchibisov mentioned this issue Mar 7, 2020
Merged
Osspial added a commit that referenced this issue Mar 9, 2020
@kchibisov @Osspial
Revert "on MacOS, Fix not sending ReceivedCharacter event for s… (#1501)
b208daa 
This reverts commit 9daa073.

This commit introduced other bug #1453 with likely much more common bindings,
so reverting it for now.

Fixes #1453.

Co-authored-by: Osspial <osspial@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B - bug Dang, that shouldn't have happened C - needs investigation Issue must be confirmed and researched DS - macos
Milestone
No milestone
2 participants
@chrisduerr @goddessfreya