Fix MSRV CI issue by pinning half to v2.2.1 #198
Conversation
This commit fixes the MSRV CI failure by pinning the half crate to version 2.2.1 Signed-off-by: John Nunley <dev@notgull.net>
There was a problem hiding this comment.
I think we should pin it in CI for MSRV runs instead of in Cargo.toml.
Even though this is a dev-dependency and won't affect downstream users, it affects tests and local-development, where we are not gonna run with the same dependencies as the majority of users: just the latest.
Unfortunately this would also be more inconvenient, but I think this is necessary until rust-lang/cargo#9930 is resolved (assuming that half uses correct MSRV entries in its releases).
Signed-off-by: John Nunley <dev@notgull.net>
.github/workflows/ci.yml
Outdated
| @@ -91,14 +91,17 @@ jobs: | |||
| shell: bash | |||
| run: cargo $CMD build --verbose --target ${{ matrix.platform.target }} $OPTIONS --features $FEATURES | |||
|
|
|||
| - name: Pin versions of dev-deps | |||
| if: matrix.rust_version == '1.65.0' | |||
| run: bash tools/fix_msrv.sh | |||
There was a problem hiding this comment.
Can't we just call cargo update -p half --precise 2.2.1?
I would prefer not to use a bash script because the lack of cross-platform support kinda defeats it's purpose compared to just putting it directly into the CI script.
There was a problem hiding this comment.
I didn't know about this command, thanks!
Signed-off-by: John Nunley <dev@notgull.net>
This commit fixes the MSRV CI failure by pinning the half crate to
version 2.2.1. We should look for a longer term solution to this
issue.