-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add haiku support #88
Conversation
Well I don't know anything about Haiku, but other than that things look good. Is there any sort of official documentation that should maybe be linked to for these fields? |
Maybe run |
closest that i know of documentation that looks official is the api documentation here. that has (a little) more information regarding BWindow and BDirectWindow i have also pushed an update with cargo fmt applied. |
If I'm reading these docs correctly, then |
i have added a note about the possibility for null for BDirectWindow. i am not sure of a case where one would want to create a BDirectWindow from BWindow. at the time of window creation, the choice would stem (at least according to the documentation) from whether the caller wishes to use the app_server or attempt to bypass it. for the former case, use BWindow. in the other case, a BDirectWindow. in regards to BWindowScreen i also noticed some note(s) on it but no real api documentation outside of some brief mentions in some documents that appeared to be in a legacy (aka outdated) area of documentation so left it out. for BDirectWindow, from what i can tell it seems that the current direction is to prefer BWindow over BDirectWindow. if it would be preferred to only include what is necessary, i am fine with leaving out the BDirectWindow reference and revisiting that at another time. however, libraries ported to haiku that deal with windowing such as libsdl had been using BDirectWindow so opted to keep it in (c.f. this) |
Sorry about the delay! |
this pr adds haiku support (BWindow and BDirectWindow)
the following is an example run of tests on a haiku instance: