fix extracting a u64 on little-endian CPUs #784
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cast-to-raw-ptr-fix was wrong, but unfortunately it takes some rather special circumstances to exhibit that which did not come up in the test suite. (Miri does not do any tracking of raw pointers, so the raw pointer used here to access the second
u32
probably get confused with some other raw pointer created previously. Eventually we will want to do proper tracking of raw pointers as well.)Also, this code path can now be used on all little-endian CPUs, at the cost of an unaligned read. Is that preferred?