Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce MSRV to 1.60 #1513

Closed
wants to merge 2 commits into from
Closed

Reduce MSRV to 1.60 #1513

wants to merge 2 commits into from

Conversation

dhardy
Copy link
Member

@dhardy dhardy commented Oct 16, 2024

  • Added a CHANGELOG.md entry

Summary

MSRV = 1.60 for build, 1.61 for tests

Motivation

This was requested.

Details

The lack of full tests on 1.60 isn't documented anywhere. Should it be?

@newpavlov
Copy link
Member

IIRC MSRV bump to 1.61 was caused by criterion. Now benchmarks reside in a separate crate outside of workspace, so it no longer applies. Is there another dev dependency which has similar MSRV?

@dhardy
Copy link
Member Author

dhardy commented Oct 16, 2024

Yes; rand uses rayon in an example, and that uses crossbeam which requires 1.61. Meanwhile rand_distr uses average as a dev-dependency which also requires 1.61.

@newpavlov
Copy link
Member

newpavlov commented Oct 16, 2024

Hm... Personally, I think it's fine to bump MSRV to 1.61 then. The motivating request was a bit strange and they have still options to not update rand or to ignore rust-version.

@dhardy
Copy link
Member Author

dhardy commented Oct 16, 2024

It doesn't cost us much, so I don't see why we shouldn't do this.

It's something I dislike about the rust-version tag actually: it should be set to the minimum version we actually want to test & support while allowing users to still try building (with a warning) on older versions.

@newpavlov
Copy link
Member

This means that MSRV is not properly tested and we get weird exceptions "we declare 1.60 support, but, well, test only for 1.61" in different places. I guess as a middle ground we could release v0.9.0 with rust-version equal to 1.60 and update it to 1.61 in v0.9.1.

while allowing users to still try building (with a warning) on older versions

They can do it by passing the --ignore-rust-version flag.

@dhardy
Copy link
Member Author

dhardy commented Oct 16, 2024

TIL about --ignore-rust-version.

Then I agree; there's no reason to merge this.

@dhardy dhardy closed this Oct 16, 2024
@dhardy dhardy mentioned this pull request Nov 14, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants