Fix IPv4 initialization for test_address_ipv4 #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The address used in the test was incorrectly initialized on big-endian hosts. Fixes rust-pcap#347.
Stargateur
approved these changes
Apr 18, 2024
|
In perfect world I would prefer a better API, probably set_addr should do the to_be() but it's only for testing soooooo. |
|
Thanks for the PR! The CI doesn't pass, but the failures are the same as on main (I just haven't gotten around to resolving them). I'll handle it and merge soon. |
|
You’re welcome! Thanks for reviewing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The address used in the test was incorrectly initialized on big-endian hosts.
Fixes #347.
I tested this as a patch using real
s390xhardware.