-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a library crate to the repo for downloading/caching prebuilts #38
Comments
Move the build code to a new build-edk2 package. This is a precursor to adding a second package to the workspace: #38
Sounds good to me overall!
Yeah, I wasn't sure about that either. I'm fine with trying a GitHub download instead, but that approach has drawbacks too (network connection required, no longer self-contained, forking more difficult, etc).
For the crate, we could do the downloading in a build script and place the artifacts in |
Move the build code to a new build-edk2 package. This is a precursor to adding a second package to the workspace: #38
As mentioned in #37 (comment), I'd like to add a library crate here, essentially an upgrade to https://crates.io/crates/ovmf-prebuilt to make it easy to get the new prebuilts.
Filing an issue here to lay out a quick plan:
build-edk2
, containing the code that's currently insrc/
.build-edk2
will not be published.ovmf-prebuilt
package to the workspace. This can start at version 0.2.0 to supersede the currently-published versions.ovmf-prebuilt
similar to what we have in uefi-rs: https://github.com/rust-osdev/uefi-rs/blob/ccdfb66cd073442e3dc08412a7c18369d906aff7/xtask/src/qemu.rs#L95. This differs from the previous approach of putting the binaries directly in the crates.io release. I couldn't find any specific policy about uploading prebuilts on crates.io, but this discussion makes it sound at least discouraged.The text was updated successfully, but these errors were encountered: