Strip debug symbols from kernel #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please add an option to disable this. Gdb attached to qemu can load debuginfo too (havent tested, but people say it works) |
|
If done properly, this shouldn't affect debugging with GDB. As I understand it, there'd be two copies of the binary - one with debug info and one without. The bootloader would simply load the one without debug info, but you could just point GDB to the one with debug info and it'd work properly. @bjorn3 |
|
Thanks @64 I thought the original was stripped in place. |
|
Yeah, the original binary is not modified. |
phil-opp
added a commit
that referenced
this pull request
Jun 24, 2019
|
bors r+ |
Merge conflict (retrying...) |
bors bot
added a commit
that referenced
this pull request
Jun 24, 2019
59: Strip debug symbols from kernel r=phil-opp a=phil-opp This PR strips debug symbols from the kernel binary to speed up loading. This reduces the boot image size from 5MB to 270KB for blog_os. (The code already works, I just want to clean it up a bit and improve the naming of the string/path variables before merging.) cc @64 Co-authored-by: Philipp Oppermann <dev@phil-opp.com>
Build failed
|
|
Failed presumably because of https://status.chocolatey.org/issues/2019-06-24-chocolatey-org-not-available-from-aws/ |
phil-opp
added a commit
that referenced
this pull request
Jun 24, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 24, 2019
59: Strip debug symbols from kernel r=phil-opp a=phil-opp This PR strips debug symbols from the kernel binary to speed up loading. This reduces the boot image size from 5MB to 270KB for blog_os. (The code already works, I just want to clean it up a bit and improve the naming of the string/path variables before merging.) cc @64 Co-authored-by: Philipp Oppermann <dev@phil-opp.com>
Build succeeded
|
|
Published as version 0.6.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR strips debug symbols from the kernel binary to speed up loading. This reduces the boot image size from 5MB to 270KB for blog_os.
(The code already works, I just want to clean it up a bit and improve the naming of the string/path variables before merging.)
cc @64