Use Mul by reference in pow
#334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main `pow` now uses `Mul` by reference, but there's not a good way to propagate that requirement from `Float`.
... which was implied by `One` already anyway.
|
bors r+ |
Build succeeded |
|
Shame i lost my commit contribute but oh well. Thanks |
|
Your commit still has you as the author, just me as the committer since I rebased it. Is that what you mean? |
|
Doesn't show in contributors for some reason. No idea how github makes those stats. Doesn't matter i just like numbers against my name haha |
|
Oh, I think that's just because it's not on master. :) |
|
Ahh. The wait begins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmission of #153, since it wasn't open to maintainer edits. I added a distinct
Float::powifallback since that doesn't haveMulby reference.cc @dten