Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline small wrapper functions #218

Closed
Ms2ger opened this issue Aug 10, 2016 · 0 comments
Closed

Inline small wrapper functions #218

Ms2ger opened this issue Aug 10, 2016 · 0 comments
Assignees
@cuviper

Comments

@Ms2ger
Copy link

Ms2ger commented Aug 10, 2016

Such as the PrimInt implementations for built-in integers.

See briansmith/ring#199 (comment)
@Ms2ger Ms2ger mentioned this issue Aug 10, 2016
Closed
@cuviper cuviper self-assigned this Aug 11, 2016
@cuviper cuviper mentioned this issue Aug 11, 2016
Merged
@homu homu closed this as completed in #219 Aug 11, 2016
homu added a commit that referenced this issue Aug 11, 2016
@homu
Auto merge of #219 - cuviper:tiny-inline, r=hauleth
10a57ef 
Inline small functions, especially wrappers

We already had `#[inline]` throughout a lot of the code, but notably some
functions which simply wrap inherent methods were not inlined.  That means
external references will get a full function call, when they could have been
optimized to as little as one opcode.

This PR inlines all functions that look tiny enough for this to matter.

Fixes #218.
remexre pushed a commit to remexre/num that referenced this issue Jun 1, 2017
@oli-obk
Merge pull request rust-num#218 from serde-rs/indexmap
6caf995 
Index into Map
@rubdos rubdos mentioned this issue Jun 20, 2017
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cuviper cuviper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cuviper @Ms2ger