Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Serde 1.0 #9

Closed
cuviper opened this issue Dec 20, 2017 · 2 comments
Closed

Update to Serde 1.0 #9

cuviper opened this issue Dec 20, 2017 · 2 comments
Labels
breaking change enhancement
Milestone
num-rational-0.2

Comments

@cuviper
Copy link
Member

cuviper commented Dec 20, 2017

See rust-num/num#281, and this was previously in the next branch after rust-num/num#305.
@cuviper cuviper added this to the num-rational-0.2 milestone Dec 20, 2017
@cuviper cuviper mentioned this issue Dec 20, 2017
Closed
3 tasks
@Emerentius
Copy link
Contributor

I see that num-rational was already updated in rust-num/num#305 but the current master is still on the old serde. Is anything blocking this? The changes are minimal, I have the code ready.

@cuviper
Copy link
Member Author

cuviper commented Apr 7, 2018

A PR would be welcome. Can you also remove rustc-serialize? Thanks!

@Emerentius Emerentius mentioned this issue Apr 7, 2018
Merged
vks added a commit to vks/num-rational that referenced this issue Apr 10, 2018
@vks
Upgrade to serde 1.0
6413523 
Fixes rust-num#9.
bors bot added a commit that referenced this issue Apr 12, 2018
@bors @Emerentius
Merge #24
06f0e26 
24: Update serde to 1.0 and remove rustc-serialize r=cuviper a=Emerentius

Fixes #9

Co-authored-by: Emerentius <emerentius@arcor.de>
@bors bors bot closed this as completed in #24 Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change enhancement
Projects
None yet
Milestone
num-rational-0.2
Development

No branches or pull requests
2 participants
@cuviper @Emerentius