Optimize BigUint::modpow for even #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While I can appreciate what you're trying to optimize, I think we need not bother -- #77 (comment) Maybe you'd be interested to try this optimization in |
|
Thanks for the comment. I will try |
|
@cuviper I replaced the commits to modpow |
|
Sorry for late review. Looks good -- I went ahead and pushed some tweaks of my own to this PR too. bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 6, 2019
93: Optimize BigUint::modpow for even r=cuviper a=youknowone ~This work is based on #77~ ~This version only allow to take `&BigUint` as `exp` argument and doesn't manipulate `exp` not to copy the data of `exp`.~ Co-authored-by: Jeong YunWon <jeong@youknowone.org> Co-authored-by: Josh Stone <cuviper@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is based on #77This version only allow to take&BigUintasexpargument and doesn't manipulateexpnot to copy the data ofexp.