Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overwrite Zero/One default impls for set_zero and set_one #82

Merged
merged 2 commits into from
Jun 1, 2019
Merged

overwrite Zero/One default impls for set_zero and set_one #82

merged 2 commits into from
Jun 1, 2019

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Mar 5, 2019 •
edited
Loading

title

cuviper
cuviper reviewed Mar 6, 2019
View reviewed changes
src/bigint.rs Outdated Show resolved Hide resolved
@lcnr lcnr changed the title overwrite Zero/One default impls for to_zero and to_one overwrite Zero/One default impls for set_zero and set_one Mar 7, 2019
@lcnr
Copy link
Contributor Author

lcnr commented Mar 31, 2019

This PR can now be merged once the new version of num-traits is available.

@cuviper
Copy link
Member

cuviper commented Jun 1, 2019

Thanks! I rebased and squashed your commits, then bumped to num-traits 0.2.7.

bors r+

bors bot added a commit that referenced this pull request Jun 1, 2019
@bors @lcnr @cuviper
Merge #82
b90ed60 
82: overwrite Zero/One default impls for `set_zero` and `set_one` r=cuviper a=lcnr

title

Co-authored-by: lcnr/Bastian Kauschke <bastian_kauschke@hotmail.de>
Co-authored-by: Josh Stone <cuviper@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jun 1, 2019

Build succeeded

@bors bors bot merged commit 7bf4b14 into rust-num:master Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuviper cuviper cuviper left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lcnr @cuviper