Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use ObligationCtxt for canonical queries #50

Closed
2 of 3 tasks
lcnr opened this issue Jul 20, 2022 · 5 comments
Closed
2 of 3 tasks

use ObligationCtxt for canonical queries #50

lcnr opened this issue Jul 20, 2022 · 5 comments
Labels
finished-final-comment-period The FCP has finished, action upon the disposition label needs to be taken major-change A major change proposal major-change-accepted An accepted major change proposal to-announce Announce this issue on triage meeting

Comments

@lcnr
Copy link
Contributor

lcnr commented Jul 20, 2022 •
edited by compiler-errors
Loading

Proposal

Canonical queries are currently implemented using an extension trait for InferCtxt and manually create a FulfillmentContext.

Considering that literally all uses of enter_with_canonical create a FulfillmentContext right away, moving all of this to ObligationCtxt seems like a sensible step to me.

Mentors or Reviewers

If you have a reviewer or mentor in mind for this work, mention then
here. You can put your own name here if you are planning to mentor the
work.

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A types team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Types team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
@compiler-errors
Copy link
Member

seconded, even if rustbot won't do anything yet

@compiler-errors compiler-errors added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Aug 1, 2022
@compiler-errors
Copy link
Member

I wonder if this works...

@rustbot second

@rustbot
Copy link
Collaborator

rustbot commented Aug 1, 2022

Error: This issue cannot be seconded; it lacks the major-change label.

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@compiler-errors compiler-errors added the major-change A major change proposal label Aug 1, 2022
@rustbot
Copy link
Collaborator

rustbot commented Aug 1, 2022

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/types

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Aug 1, 2022
@compiler-errors
Copy link
Member

@rustbot second

@jackh726 jackh726 added major-change-accepted An accepted major change proposal finished-final-comment-period The FCP has finished, action upon the disposition label needs to be taken and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Aug 12, 2022
@compiler-errors compiler-errors mentioned this issue Oct 26, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Nov 1, 2022
@bors
Auto merge of rust-lang#103590 - compiler-errors:ocx-more, r=lcnr
e70cbef 
(almost) Always use `ObligationCtxt` when dealing with canonical queries

Hope this is a step in the right direction. cc rust-lang/types-team#50.

r? `@lcnr`
RalfJung pushed a commit to RalfJung/miri that referenced this issue Nov 5, 2022
@bors
Auto merge of #103590 - compiler-errors:ocx-more, r=lcnr
c143193 
(almost) Always use `ObligationCtxt` when dealing with canonical queries

Hope this is a step in the right direction. cc rust-lang/types-team#50.

r? `@lcnr`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
finished-final-comment-period The FCP has finished, action upon the disposition label needs to be taken major-change A major change proposal major-change-accepted An accepted major change proposal to-announce Announce this issue on triage meeting
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nikomatsakis @compiler-errors @lcnr @jackh726 @rustbot