Update comment search in ControlFlow::rewrite_pat_expr for for loops #5016
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5009
For loops represented by a ControlFlow object use
" in"
as their connector.In order to find the span where comments might be located, rustfmt
searches for the first uncommented occurrence of the word
"in"
within thecurrent span and adjusts it's starting point to look for comments right after that.
visually this looks like this:
This works well in most cases, however when the pattern also contains
the word
"in"
, this leads to issues.In order to correctly identify the connector, the new approach first
updates the span to start after the pattern and then searches for the
first uncommented occurrence of
"in"
.