don't convert implict ABI when doing so could fail to preserve semantics #4293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebcartwright
commented
Jun 30, 2020
calebcartwright
commented
Jun 30, 2020
Comment on lines
+76
to
+82
| // Users that have an existing explicit ABI would need to convert to implicit | ||
| // manually, as rustfmt will be conservative and not attempt to convert explicit | ||
| // to implicit in the wasm case. | ||
| #[wasm_bindgen] | ||
| extern "C" { | ||
| fn foo() -> Bar; | ||
| } |
There was a problem hiding this comment.
Unfortunately I believe that an explicit C ABI became common practice with wasm_bindgen at least in part because of rustfmt 1.x behavior. However, I don't think we should attempt to help those users convert back to an implicit ABI as it seems to risky/error prone IMO; with this change, rustfmt 2.0 by default would permit users to do what they want and will no longer force Explicit ABIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2908 (option 3 from #2908 (comment))
Happy to open a separate/alternative PR with option 2 if we'd rather go that route 👍