Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include constness in impl blocks #4215

Merged
merged 1 commit into from
May 31, 2020
Merged

Conversation

ayazhafiz
Copy link
Contributor

Closes #4084

Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though will defer to @topecongiro on whether to merge this before or after #4212 given the file/directory changes

Copy link
Contributor

@topecongiro topecongiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@topecongiro topecongiro merged commit c6c9c7f into rust-lang:master May 31, 2020
calebcartwright pushed a commit to calebcartwright/rustfmt that referenced this pull request Jan 27, 2021
calebcartwright pushed a commit that referenced this pull request Jan 28, 2021
@karyon
Copy link
Contributor

karyon commented Oct 25, 2021

backported in #4673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants