change default edition to 2018 #3942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebcartwright
commented
Nov 26, 2019
| @@ -62,7 +62,7 @@ use foo::{baz, qux as bar}; | |||
| use ::foo; | |||
| use ::foo::{Bar}; | |||
| use ::foo::{Bar, Baz}; | |||
| use ::{Foo}; | |||
| use ::{qux}; | |||
There was a problem hiding this comment.
This was changed due to an existing bug I discovered during this process that only surfaces when using the 2018 edition (we didn't see it before because the default edition was 2015).
I've opened #3943 to track that separate issue
|
Thank you! |
|
I believe this won't be backported, right @calebcartwright? |
Correct 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3517 and refs #3887
Unsurprisingly changing the default edition from 2015 to 2018 required updates to a few tests as well to account for changes.
try!macro was deprecated in Rust v1.39.0, and sincetryis a reserved word in the 2018 edition, the raw identifier has to be used (r#try!) when using the 2018 edition - https://doc.rust-lang.org/std/macro.try.html