Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate skip_children option #3895

Merged
merged 5 commits into from
Oct 29, 2019
Merged

deprecate skip_children option #3895

merged 5 commits into from
Oct 29, 2019

Conversation

scampi
Copy link
Contributor

@scampi scampi commented Oct 27, 2019

Close #3893

topecongiro
topecongiro reviewed Oct 28, 2019
View reviewed changes
Copy link
Contributor

@topecongiro topecongiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, LGTM other than the dbg! call.

src/config/config_type.rs Outdated Show resolved Hide resolved
topecongiro
topecongiro suggested changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@topecongiro topecongiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, could you fix the CI errors? Also, I wonder why Travis is green even when some of the tests have failed 🤔

src/bin/main.rs Outdated Show resolved Hide resolved
src/config/config_type.rs Outdated Show resolved Hide resolved
scampi added 2 commits October 28, 2019 09:36
@scampi
remove dbg statement
6b599e6
@scampi
fix test build script
d57f94a 
`cargo test` failed because of the too long lines but the build passed
anyway because `cargo test -- --ignored` did. The script should be a
single command.

https://docs.travis-ci.com/user/deployment/script/
@scampi
Copy link
Contributor Author

scampi commented Oct 28, 2019 •
edited
Loading

@topecongiro the Travis build now correctly fails when test fail d57f94a

@scampi
Copy link
Contributor Author

scampi commented Oct 28, 2019

The beta build failed because of some reason unrelated to this PR. I'll try to check why.

error: invalid suffix `x` for integer literal
 --> tests/source/issue-3779/ice.rs:2:5
  |
2 |     1x;
  |     ^^ invalid suffix `x`
  |
  = help: the suffix must be one of the integral types (`u32`, `isize`, etc)

@calebcartwright
Copy link
Member

That was added as part of #3782, though that file is supposed to be ignored

@calebcartwright
Copy link
Member

calebcartwright commented Oct 28, 2019 •
edited
Loading

There's warning about unstable options in the output just above the failure which means that file isn't being ignore'd like it should be

Warning: can't set `unstable_features = true`, unstable features are only available in nightly channel.
Warning: can't set `ignore = IgnoreList { path_set: {"tests/**/issue-3779/ice.rs"}, rustfmt_toml_path: "" }`, unstable features are only available in nightly channel.

Any reason why the unstable options wouldn't be working on that one?

@topecongiro topecongiro merged commit 09a028b into master Oct 29, 2019
@topecongiro topecongiro deleted the issue-3893 branch October 29, 2019 00:33
@scampi
Copy link
Contributor Author

scampi commented Oct 29, 2019

@calebcartwright I'll have a look about why ice.rs is not ignored.

@calebcartwright
Copy link
Member

@scampi - I believe I found the issue and have opened #3897 with fixes. I added these tests but missed the unstable/nightly check which is why they were failing on beta.

My apologies!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topecongiro topecongiro topecongiro requested changes

Assignees
No one assigned
Labels
backport-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deprecate skip_children option
4 participants
@scampi @calebcartwright @topecongiro @karyon