do not force comments to be indented with a comment trailing a line of code #3833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topecongiro
added a commit
to topecongiro/rustfmt
that referenced
this pull request
Oct 27, 2019
…a line of code (rust-lang#3833)" This reverts commit fb01dc8.
Merged
topecongiro
added a commit
to topecongiro/rustfmt
that referenced
this pull request
Dec 3, 2019
…a line of code (rust-lang#3833)" This reverts commit fb01dc8.
topecongiro
added a commit
to topecongiro/rustfmt
that referenced
this pull request
Dec 15, 2019
…a line of code (rust-lang#3833)" This reverts commit fb01dc8.
|
Why do I still have the same symptoms? My windows 10's rustfmt version is 1.5.1-stable (d5a82bbd 2023-02-07). |
The changes made here were largely version gated to avoid breaking the formatting stability guarantee. It's hard to speak to the specifics of your scenario without knowing anything about those specifics, but most likely if you were to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposed change assumes that a trailing comment belongs to the code on the same line. To prevent it being mixed with possible comments below it, that trailing comment is not rewritten together with the rest. For the same reason, it does not attempt to wrap the trailing comment.
Close #3792
Close #3826
Close #2996
Close #3254