remove unused const_fn feature #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Turns out the |
|
Looking at the CI logs, I have no idea how to tell what actually went wrong... |
|
@Mark-Simulacrum I updated the PR to remove the |
|
You'll also need to update this commit hash I think - https://github.com/rust-lang/rust/blob/ca82264ec7556a6011b9d3f1b2fd4c7cd0bc8ae2/src/ci/pgo.sh#L15 But merging this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I verified that
packed-simdstill builds with a recent nightly.I think the
const_fnfeature instyle-servois probably also unused (and should be removed since we plan to remove that feature flag), but I can't build-test that: it fails to build even on rustc-perf master.