Fix new warnings generated on nightly #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may have caused patches to be applied in the wrong order; that should now be fixed. In practice I think our patches likely worked out the same, but hard to be sure. A quick check with sort and sort -n seems to imply things are probably fine, but it may not have worked.
|
We'll likely want to be a little careful around deploying this -- any builds over the edge (before this PR / after this PR) may have changes as a result of the first commit here. But we do want that patch so I think we should just do this and keep an eye out for any weird perf results (most of which will go away with a re-run if they're try builds). cc @pnkfelix @rylev -- may arise in triage next week, so pinging here. Not sure who is up next week. Likely to be a change limited to just 1-2 patched incr scenarios, with (probably) high numeric indices. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit fixes a bug, and could affect benchmarks -- particularly if the string-wise path sort didn't match the numeric sort. Not sure if that happened in practice.
Second commit just drops an unused struct.
cc rust-lang/rust#88900 (actionable and real cases, fwiw)