-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove details about chalk and point to Chalk Book instead. #679
Conversation
wow, wasn't aware there's so much chalk doc here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @crlf0710! This is cleanup that has been on my TODO list for a long time.
I have two concerns:
- I don't know if there is any non-chalk-specific knowledge in these chapters that we should condense and keep in some form
- I don't know if any of the chalk-rustc integration content is still relevant. I understood it to be all out of date. So perhaps we should just mention that there is some experimental effort to do integration and leave it at that?
I would really appreciate some guidance from @rust-lang/wg-traits on this...
src/SUMMARY.md
Outdated
- [An Overview of Chalk](./traits/chalk-overview.md) | ||
- [Bibliography](./traits/bibliography.md) | ||
- [Chalk-based trait solving](./traits/chalk.md) | ||
- [Region constraints](./traits/regions.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just remove this subchapter and delete ./traits/region.md
Let's see, going over the sections:
The WF section states "The new-style WF checking has not been implemented in rustc yet", so I think there isn't much. Mentioning something like that sounds like a good plan. |
Addressed the comments above. Please review again to see if there's more to be adjusted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @crlf0710 ! This looks great :)
I have two minor nits, but after that r=me
Wait, https://rust-lang.github.io/chalk/book/ is now 404. Did we have a url change or something? EDIT: pending on https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/Chalk.20book.20address.20change.2E |
Co-Authored-By: Who? Me?! <mark-i-m@users.noreply.github.com>
Comments are addressed, and seems CI passes now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
Now that these contents have been moved to the Chalk Book, this PR remove these contents and point to that instead.