Edit bootstrapping chapter #1239
Conversation
src/building/bootstrapping.md
Outdated
| However, since it was built with an older compiler (stage0), | ||
| it was not compiled with any new optimizations in compiler source code. | ||
| To optimize the stage1 compiler we go to the next stage. |
There was a problem hiding this comment.
I think talking about optimizations here is misleading. The main reason to build stage2 is so the ABI for the dynamic libraries (rustc_private) matches the ABI of the compiler itself.
Maybe we should consolidate some of this information with the "understanding stages of bootstrap" section?
There was a problem hiding this comment.
I think as long as we don't say "optimizations are the reason for this stage", mentioning them here as an example gives an unfamiliar reader an easy-to-understand example.
There was a problem hiding this comment.
So To optimize the stage1 compiler we go to the next stage should be removed, yes.
|
Thanks, this looks great! Do you mind squashing the commits a little? r=me after that :) |
Use paragraphs instead of bullet-points. Edits throughout for clarity. Use semantic line breaks in edited sections. Co-authored-by: Joshua Nelson <github@jyn.dev>
|
Done. r=@jyn514 |
The italics added in #1239 broke the implicitly-resolved link.
The italics added in #1239 broke the implicitly-resolved link.
The italics added in rust-lang#1239 broke the implicitly-resolved link.
Mainly revises the stages overview, using paragraphs instead of bullet points.