Skip to content

Commit

Permalink
fix words on r=someone
Browse files Browse the repository at this point in the history
Co-authored-by: Yuki Okushi <jtitor@2k36.org>
  • Loading branch information
chenyukang and JohnTitor authored Jan 20, 2024
1 parent 527e0ad commit 6a49e49
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/walkthrough.md
Original file line number Diff line number Diff line change
Expand Up @@ -196,8 +196,9 @@ Feel free to ask questions or discuss things you don't understand or disagree wi
recognize that the PR won't be merged unless someone on the Rust team approves
it. If a reviewer leave a comment like `r=me after fixing ...`, that means they approve the PR and
you can merge it with comment with `@bors r=reviwer-github-id`(e.g. `@bors r=eddyb`) to merge it
after fixing lefted trivial issues. `r=someone` requires permission and the reviwer use
delegate command gives it to you in this way.
after fixing trivial issues. Note that `r=someone` requires permission and bors could say something like
"🔑 Insufficient privileges..." when commenting `r=someone`. In that case, you have to ask the reviewer
to revisit your PR.

When your reviewer approves the PR, it will go into a queue for yet another bot
called `@bors`. `@bors` manages the CI build/merge queue. When your PR reaches
Expand Down

0 comments on commit 6a49e49

Please sign in to comment.