Lock stdout once when listing tests #99627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
|
(rust-highfive has picked a reviewer for you, use r? to override) |
eddyb
reviewed
Jul 23, 2022
| None => OutputLocation::Raw(io::stdout()), | ||
| None => OutputLocation::Raw(io::stdout().lock()), |
There was a problem hiding this comment.
Ahhh classic mistake! Reminds me of this (which was native execution, but hit a syscall instead of lock):
|
@bors r+ |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 23, 2022
Lock stdout once when listing tests This is a marginal optimization for normal operation, but for `cargo miri nextest list` (which is invoked by `cargo miri nextest run`) this knocks the startup time on `regex` down from 87 seconds to 17 seconds. Still slow, but a nice 5x improvement.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 23, 2022
…laumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#99298 (Make `ui-fulldeps/gated-plugins` and `ui-fulldeps/multiple-plugins` tests stage 2 only) - rust-lang#99396 (Add some additional double-adjustment regression tests) - rust-lang#99449 (Do not resolve associated const when there is no provided value) - rust-lang#99595 (Mark atomics as unsupported on thumbv6m) - rust-lang#99627 (Lock stdout once when listing tests) - rust-lang#99638 (Remove Clean trait implementation for hir::Ty and middle::Ty) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a marginal optimization for normal operation, but for
cargo miri nextest list(which is invoked bycargo miri nextest run) this knocks the startup time onregexdown from 87 seconds to 17 seconds. Still slow, but a nice 5x improvement.