-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register opaque types even when equated with infer variables #99547
Closed
compiler-errors
wants to merge
1
commit into
rust-lang:master
from
compiler-errors:cursed-equate-opaque
Closed
Register opaque types even when equated with infer variables #99547
compiler-errors
wants to merge
1
commit into
rust-lang:master
from
compiler-errors:cursed-equate-opaque
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
r? @oli-obk |
d99be45
to
5fcd47e
Compare
What the heck. Why did that commit get pushed, lol. |
5fcd47e
to
737ae12
Compare
There. |
737ae12
to
8d92e49
Compare
But anyways it seems like the behavior chosen that this PR tries to "fix" was intentional. So, gonna close this. |
The job Click to see the possible cause of the failure (guessed by this bot)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: This doesn't work, but it does fix #99536. Just putting this code up for other people's eyes.
The issue this attempts to solve here is that when we
Equate::tys
on an inference variable and an opaque type, we end up just storing the opaque type in the type variable table, instead of handling the opaque type as we should be doing.Thoughts on this? cc @oli-obk in particular. I'd like to work towards a real working solution if possible, if this approach has any merit.