Revert "Stabilize $$ in Rust 1.63.0" #99435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9edaa76.
|
r? @cjgillot (rust-highfive has picked a reviewer for you, use r? to override) |
Closed
|
Trying again... @rustbot modify labels +T-compiler +T-lang +beta-nominated +relnotes |
|
Trying again... @rustbot modify labels +T-lang |
|
@bors r+ |
|
Whoops, I have no idea how the |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 19, 2022
…askrgr Rollup of 9 pull requests Successful merges: - rust-lang#98028 (Add E0790 as more specific variant of E0283) - rust-lang#99384 (use body's param-env when checking if type needs drop) - rust-lang#99401 (Avoid `Symbol` to `&str` conversions) - rust-lang#99419 (Stabilize `core::task::ready!`) - rust-lang#99435 (Revert "Stabilize $$ in Rust 1.63.0") - rust-lang#99438 (Improve suggestions for `NonZeroT` <- `T` coercion error) - rust-lang#99441 (Update mdbook) - rust-lang#99453 (:arrow_up: rust-analyzer) - rust-lang#99457 (use `par_for_each_in` in `par_body_owners` and `collect_crate_mono_items`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
Will a team member do the beta backport or should I go ahead and cherry-pick this onto the beta branch (assuming it gets beta-approved)? |
|
@CAD97 Can you also post a revert of rust-lang/reference#1192 to the reference repo? As for beta process, someone on the team first needs to mark this with the
beta-accepted
|
|
@rustbot label: +beta-accepted |
ehuss
added a commit
to ehuss/rust
that referenced
this pull request
Jul 22, 2022
This is in preparation to merge rust-lang#99435 which will require the toolstate to be passing. 1 commits in 9fce337a55ee4a4629205f6094656195cecad231..dd07eda38b15f756d60556b7bd7eed6d8db3eeca 2022-06-22 13:59:28 -0700 to 2022-07-21 19:05:26 -0700 - This reverts commit 151b8196a30b1c00cb422e25f459dd4354043a6a, reversing (rust-lang/reference#1192)
ehuss
pushed a commit
to ehuss/rust
that referenced
this pull request
Jul 22, 2022
…=Mark-Simulacrum Revert "Stabilize $$ in Rust 1.63.0" This mechanically reverts commit 9edaa76, the one commit from rust-lang#95860. rust-lang#99035; the behavior of `$$crate` is potentially unexpected and not ready to be stabilized. rust-lang#99193 attempts to forbid `$$crate` without also destabilizing `$$` more generally. `@rustbot` modify labels +T-compiler +T-lang +P-medium +beta-nominated +relnotes (applying the labels I think are accurate from the issue and alternative partial revert) cc `@Mark-Simulacrum`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 22, 2022
[beta] Beta 1.63 backports * Reference: Revert $$ macro_metavar rust-lang/reference#1192 * Revert "Stabilize $$ in Rust 1.63.0" rust-lang#99435 * rustdoc: avoid inlining items with duplicate `(type, name)` rust-lang#99344 * Do not call `check_expr` twice in `check_compatible` rust-lang#99397
|
reference revert happened: rust-lang/reference#1242 |
cedricschwyter
added a commit
to KyrillGobber/huehuehue
that referenced
this pull request
Jul 1, 2023
refactor:higher-order http method macro we want to switch to rust nightly to be able to make use of rust metavariable expansions as defined by RFC rust-lang/rfcs#3086 and as tracked by rust-lang/rust#83527. other references include rust-lang/rust#99035. this feature was stabilized in 1.63, then unstabilized again in rust-lang/rust#99435 and is now only available in rust nightly, awaiting restabilization. however, the feature is stable enough for our use case, which is why i'm going ahead and enabling it.
cedricschwyter
added a commit
to KyrillGobber/huehuehue
that referenced
this pull request
Jul 1, 2023
refactor:higher-order http method macro we want to switch to rust nightly to be able to make use of rust metavariable expansions as defined by RFC rust-lang/rfcs#3086 and as tracked by rust-lang/rust#83527. other references include rust-lang/rust#99035. this feature was stabilized in 1.63, then unstabilized again in rust-lang/rust#99435 and is now only available in rust nightly, awaiting restabilization. however, the feature is stable enough for our use case, which is why i'm going ahead and enabling it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mechanically reverts commit 9edaa76, the one commit from #95860.
#99035; the behavior of
$$crateis potentially unexpected and not ready to be stabilized. #99193 attempts to forbid$$cratewithout also destabilizing$$more generally.@rustbot modify labels +T-compiler +T-lang +P-medium +beta-nominated +relnotes
(applying the labels I think are accurate from the issue and alternative partial revert)
cc @Mark-Simulacrum