Remove comment referring to constness.rs #99241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri |
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @fee1-dead (or someone else) soon. Please see the contribution instructions for more information. |
|
I don't think referring to any file would work. AFAIK symbol.rs is sorted alphabetically, while this match expression is not sorted. So I believe this comment should just be removed, since there is no syncing of ordering of matches to be done. Thanks for catching it, by the way! If you have time would you mind implementing the suggested change? Or I could commit it for you if you want. |
This commit removes the comment in emulate_intrinsic, which is currently referring to 'src/librustc_middle/ty/constness.rs'.
45611ce to
ed73037
Compare
|
LGTM, Thanks! @bors r+ rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 15, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#99113 (Simplify [a]rc code a little) - rust-lang#99131 (Add label for generic arg (+ APIT) and RPIT callables in `label_fn_like`) - rust-lang#99237 (removed unused CSS and unused HTML IDs) - rust-lang#99239 (Add myself to the set of people notified when MIR changes.) - rust-lang#99241 (Remove comment referring to constness.rs) - rust-lang#99257 (Add regression test for rust-lang#89436) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the comment in emulate_intrinsic, which is
currently referring to
src/librustc_middle/ty/constness.rs.