Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Check that closures satisfy their where bounds" #97642

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Revert "Check that closures satisfy their where bounds" #97642

merged 1 commit into from
Jun 13, 2022

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jun 2, 2022 •
edited
Loading

This reverts commit 253408b from #96899

This is only performed on beta to give us another few weeks to fix #97607 on nightly. The planned fix is likely way too large to backport anyway.

r? @compiler-errors

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 2, 2022
@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 2, 2022
@compiler-errors
Copy link
Member

r=me pending beta approval

@oli-obk oli-obk added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 2, 2022
@compiler-errors compiler-errors added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jun 2, 2022
@compiler-errors
Copy link
Member

This was approved during the compiler meeting: https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202022-06-02/near/284757867

@bors r+

@bors
Copy link
Contributor

bors commented Jun 2, 2022

📌 Commit 4eb9823a84b3139e5e0a3592f1639245910905f9 has been approved by compiler-errors

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2022
@compiler-errors
Copy link
Member

@bors rollup=never

@bors
Copy link
Contributor

bors commented Jun 3, 2022

⌛ Testing commit 4eb9823a84b3139e5e0a3592f1639245910905f9 with merge 26963b169962e7a5fd396ff004ae058ee3c9755b...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Jun 3, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 3, 2022
@compiler-errors compiler-errors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2022
@oli-obk oli-obk force-pushed the backport_undo_closure_wf_check branch from 4eb9823 to a0bf36c Compare June 13, 2022 10:34
@oli-obk
Copy link
Contributor Author

oli-obk commented Jun 13, 2022

@bors r=compiler-errors (rebased and blessed)

@bors
Copy link
Contributor

bors commented Jun 13, 2022

📌 Commit a0bf36c has been approved by compiler-errors

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 13, 2022
@bors
Copy link
Contributor

bors commented Jun 13, 2022

⌛ Testing commit a0bf36c with merge 1bc802e...

@bors
Copy link
Contributor

bors commented Jun 13, 2022

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 1bc802e to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 13, 2022
@bors bors merged commit 1bc802e into rust-lang:beta Jun 13, 2022
@rustbot rustbot added this to the 1.62.0 milestone Jun 13, 2022
@ehuss ehuss removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 23, 2022
@compiler-errors compiler-errors mentioned this pull request Jun 24, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
7 participants
@oli-obk @rust-highfive @compiler-errors @bors @rust-log-analyzer @ehuss @rustbot