errors: simplify referring to fluent attributes #97357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
0ee959c to
2ac3740
Compare
oli-obk
reviewed
May 30, 2022
oli-obk
reviewed
May 30, 2022
|
|
||
| match self { | ||
| DiagnosticMessage::Str(s) => DiagnosticMessage::Str(s.clone()), | ||
| DiagnosticMessage::FluentIdentifier(id, _) => { |
There was a problem hiding this comment.
Does this ever happen where then _ is Some already?
There was a problem hiding this comment.
It shouldn't as the code is written right now, but it wouldn't be much of a problem if it did. I considered adding a panic or something like that.
oli-obk
approved these changes
May 30, 2022
To render the message of a Fluent attribute, the identifier of the Fluent message must be known. `DiagnosticMessage::FluentIdentifier` contains both the message's identifier and optionally the identifier of an attribute. Generated constants for each attribute would therefore need to be named uniquely (amongst all error messages) or be able to refer to only the attribute identifier which will be combined with a message identifier later. In this commit, the latter strategy is implemented as part of the `Diagnostic` type's functions for adding subdiagnostics of various kinds. Signed-off-by: David Wood <david.wood@huawei.com>
2ac3740 to
f669b78
Compare
|
@bors r=oli-obk |
|
📌 Commit f669b78 has been approved by |
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
May 30, 2022
…ped-subdiagnostic-simplification, r=oli-obk errors: simplify referring to fluent attributes To render the message of a Fluent attribute, the identifier of the Fluent message must be known. `DiagnosticMessage::FluentIdentifier` contains both the message's identifier and optionally the identifier of an attribute. Generated constants for each attribute would therefore need to be named uniquely (amongst all error messages) or be able to refer to only the attribute identifier which will be combined with a message identifier later. In this commit, the latter strategy is implemented as part of the `Diagnostic` type's functions for adding subdiagnostics of various kinds. r? `@oli-obk`
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (7be9ec2): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Footnotes |
|
visiting for rustc-perf performance triage. There were some regressions here, but they are few, minor, and contained solely to secondary benchmarks (specifically projection-caching and wg-grammar). Marking as triaged. @rustbot label: perf-regression-triaged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To render the message of a Fluent attribute, the identifier of the Fluent message must be known.
DiagnosticMessage::FluentIdentifiercontains both the message's identifier and optionally the identifier of an attribute. Generated constants for each attribute would therefore need to be named uniquely (amongst all error messages) or be able to refer to only the attribute identifier which will be combined with a message identifier later. In this commit, the latter strategy is implemented as part of theDiagnostictype's functions for adding subdiagnostics of various kinds.r? @oli-obk