-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do writeback of Closure params before visiting the parent expression #97302
Conversation
r? @cjgillot (rust-highfive has picked a reviewer for you, use r? to override) |
I don't know this code well. What are the general effects of |
@cjgillot: I'm pretty sure everything in As far as I can tell, this just changes the order that we discover hir nodes with unresolved inference vars in their types, so we provide a more specific error message in the closure case above. |
@bors r+ |
📌 Commit e9215bb has been approved by |
Rollup of 5 pull requests Successful merges: - rust-lang#97302 (Do writeback of Closure params before visiting the parent expression) - rust-lang#97328 (rustc: Fix ICE in native library error reporting) - rust-lang#97351 (Output correct type responsible for structural match violation) - rust-lang#97398 (Add regression test for rust-lang#82830) - rust-lang#97400 (Fix a typo on Struct `Substructure`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This means that given the expression:
We will visit the HIR node for
a
beforex
, and report the ambiguity on the former instead of the latter. This also moves writeback for struct field ids and const blocks before, but the ordering of this and walking the expr doesn't seem to matter.