Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Miri #97247

Merged
merged 1 commit into from
May 21, 2022
Merged

update Miri #97247

merged 1 commit into from
May 21, 2022

Conversation

RalfJung
Copy link
Member

Fixes #97204
r? @ghost

@RalfJung
Copy link
Member Author

Cc @rust-lang/miri
@bors r+ p=1

@bors
Copy link
Contributor

bors commented May 21, 2022

📌 Commit cb4d79a has been approved by RalfJung

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 21, 2022
@bors
Copy link
Contributor

bors commented May 21, 2022

⌛ Testing commit cb4d79a with merge 74b1369...

@bors
Copy link
Contributor

bors commented May 21, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 74b1369 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 21, 2022
@bors bors merged commit 74b1369 into rust-lang:master May 21, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 21, 2022
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #97247!

Tested on commit 74b1369.
Direct link to PR: #97247

🎉 miri on windows: build-fail → test-pass (cc @RalfJung @oli-obk @eddyb).
🎉 miri on linux: build-fail → test-pass (cc @RalfJung @oli-obk @eddyb).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request May 21, 2022
@rust-highfive
📣 Toolstate changed by rust-lang/rust#97247!
eeb7958 
Tested on commit rust-lang/rust@74b1369.
Direct link to PR: <rust-lang/rust#97247>

🎉 miri on windows: build-fail → test-pass (cc @RalfJung @oli-obk @eddyb).
🎉 miri on linux: build-fail → test-pass (cc @RalfJung @oli-obk @eddyb).
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (74b1369): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: mixed results
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 0 2 0 3 0
mean2 N/A 2.5% N/A -1.5% N/A
max N/A 3.1% N/A -1.7% N/A

Cycles

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: mixed results
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 0 4 0 1 0
mean2 N/A 3.8% N/A -2.4% N/A
max N/A 4.4% N/A -2.4% N/A

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. number of relevant changes ↩ ↩2

  2. the arithmetic mean of the percent change ↩ ↩2

@RalfJung RalfJung deleted the miri branch May 22, 2022 06:02
@RalfJung
Copy link
Member Author

The Mac RSS changes are very surprising since this PR did not even change rustc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#97027
5 participants
@RalfJung @bors @rust-highfive @rust-timer @rustbot