-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error for missing cmake #96659
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. Please see the contribution instructions for more information. |
@bors r+ |
📌 Commit 9f604007c7970a87d03b1325603012b1d3a1b541 has been approved by |
@bors r- Actually, can you squash the commits? r=me with that done. |
9f60400
to
bdca737
Compare
@bors r=Mark-Simulacrum Squashed the commits. |
@Mark-Simulacrum I have squashed the commits. I think that I may have misunderstood what command was meant by |
Yeah, that just means I will approve but doesn't let you do that. Thanks for squashing! @bors r+ |
📌 Commit bdca737 has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (4c09a33): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This PR updates the error message for a missing
cmake
to be more in line with the error message for a missing installation ofninja
.The original issue, (#90679), suggests that both
ninja
andcmake
are only needed for building LLVM, so I have included the suggestion fromninja
to setdownload-ci-llvm = true
if the user would rather download LLVM. Ifcmake
actually is used in other areas, I can remove that part of the message.Fixes: #90679