Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error for missing cmake #96659

Merged
merged 1 commit into from
May 8, 2022
Merged

Conversation

thatzopoulos
Copy link
Contributor

@thatzopoulos thatzopoulos commented May 3, 2022

This PR updates the error message for a missing cmake to be more in line with the error message for a missing installation of ninja.
The original issue, (#90679), suggests that both ninja and cmake are only needed for building LLVM, so I have included the suggestion from ninja to set download-ci-llvm = true if the user would rather download LLVM. If cmake actually is used in other areas, I can remove that part of the message.

Fixes: #90679

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 3, 2022
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented May 7, 2022

📌 Commit 9f604007c7970a87d03b1325603012b1d3a1b541 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2022
@Mark-Simulacrum
Copy link
Member

@bors r-

Actually, can you squash the commits? r=me with that done.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 7, 2022
@thatzopoulos
Copy link
Contributor Author

@bors r=Mark-Simulacrum

Squashed the commits.

@thatzopoulos
Copy link
Contributor Author

@Mark-Simulacrum I have squashed the commits. I think that I may have misunderstood what command was meant by r=me.

@Mark-Simulacrum
Copy link
Member

Yeah, that just means I will approve but doesn't let you do that. Thanks for squashing!

@bors r+

@bors
Copy link
Contributor

bors commented May 7, 2022

📌 Commit bdca737 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 7, 2022
@bors
Copy link
Contributor

bors commented May 8, 2022

⌛ Testing commit bdca737 with merge 4c09a33...

@bors
Copy link
Contributor

bors commented May 8, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 4c09a33 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 8, 2022
@bors bors merged commit 4c09a33 into rust-lang:master May 8, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 8, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (4c09a33): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message for cmake could meet bar set by that for ninja
6 participants