Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HashMap doc: Don't use monospace font for 'Entry Api' #96481

Merged
merged 1 commit into from
Apr 29, 2022
Merged

HashMap doc: Don't use monospace font for 'Entry Api' #96481

merged 1 commit into from
Apr 29, 2022

Conversation

aDotInTheVoid
Copy link
Member

No description provided.

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Apr 27, 2022
@rust-highfive
Copy link
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 27, 2022
joshtriplett
joshtriplett reviewed Apr 27, 2022
View reviewed changes
library/std/src/collections/hash/map.rs Outdated
@@ -136,7 +136,7 @@ use crate::sys;
/// ]);
/// ```
///
/// `HashMap` implements an [`Entry API`](#method.entry), which allows
/// `HashMap` implements an [Entry API](#method.entry), which allows
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// `HashMap` implements an [Entry API](#method.entry), which allows
/// `HashMap` implements an [`Entry` API](#method.entry), which allows

Entry is a type, so wrapping it in backquotes makes sense. But I agree that "API" shouldn't be.

@aDotInTheVoid aDotInTheVoid force-pushed the hashmap-docs-monospace branch from 5228f7d to d34f8d2 Compare April 27, 2022 16:59
@joshtriplett
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 27, 2022

📌 Commit d34f8d2 has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Apr 29, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 29, 2022
@bors
Auto merge of rust-lang#96548 - Dylan-DPC:rollup-m3xkqxg, r=Dylan-DPC
87937d3 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#96477 (Update data layout string for wasm64-unknown-unknown)
 - rust-lang#96481 (HashMap doc: Don't use monospace font for 'Entry Api')
 - rust-lang#96492 (Revert "Re-export core::ffi types from std::ffi")
 - rust-lang#96516 (Revert diagnostic duplication and accidental stabilization)
 - rust-lang#96523 (Add ``@feat.00`` symbol to symbols.o for COFF)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit db1ec25 into rust-lang:master Apr 29, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshtriplett joshtriplett joshtriplett left review comments

Assignees

@joshtriplett joshtriplett

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
5 participants
@aDotInTheVoid @rust-highfive @joshtriplett @bors @rustbot