-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't build the full compiler before running unit tests #95445
Conversation
This has been present since `builder.ensure` was first added in rust-lang#43059. It's unclear to me why it was added then - I tested these changes locally with `x test compiler/rustc_data_structures --stage 0` and they worked fine. Fixes rust-lang#51748.
(rust-highfive has picked a reviewer for you, use r? to override) |
@bors r+ rollup |
📌 Commit ae12597 has been approved by |
@Dylan-DPC please don't rollup sensitive bootstrap changes like this; it's not unheard of for them to only fail in a full bors test, and I don't really have a way of replicating all those tests locally. |
Rollup of 5 pull requests Successful merges: - rust-lang#95445 (Don't build the full compiler before running unit tests) - rust-lang#95470 (Fix last rustdoc-gui spurious test) - rust-lang#95478 (Add note to the move size diagnostic) - rust-lang#95495 (Remove unneeded `to_string` call) - rust-lang#95505 (Fix library/std compilation on openbsd.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
In general the likely intent here was that if some of our unit tests (as seems not unlikely, though perhaps wrong and fixable) are making use of |
Ah, interesting, that sounds possible. But we should be able to fix it by adding to dev-dependencies, right? Unless we have a situation where e.g. a test for rustc_lexer depends on rustc_driver ... but that seems kind of cursed and at that point it should probably just be a UI test. Anyway, I'll run --stage 1 tests of all the compiler crates to make sure this doesn't break them :) |
Well, in theory there's nothing wrong with rustc_lexer depending on rustc_driver as a dev-dep (beyond "why???") from Cargo's perspective I think. But yes, I think it should be fixable unless I'm missing something, just that as-is this may break things. I wish we had a better way of reviewing and testing these patches, but as-is I am tempted to r- this sort of thing (or I guess we can wait till someone reports breakage...). |
Ok, I ran |
That seems likely good enough for now. |
This has been present since
builder.ensure
was first added in #43059.It's unclear to me why it was added then - I tested these changes locally
with
x test compiler/rustc_data_structures --stage 0
and they worked fine.Fixes #51748.