Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Miri #95282

Merged
merged 1 commit into from
Mar 25, 2022
Merged

update Miri #95282

merged 1 commit into from
Mar 25, 2022

Conversation

RalfJung
Copy link
Member

Fixes #95258
r? @ghost

@RalfJung
Copy link
Member Author

Cc @rust-lang/miri
@bors r+ p=1

@RalfJung
Copy link
Member Author

Hello, bors?
@bors ping

There's no CI on this PR either, but https://www.githubstatus.com/ is green... someone isn't telling the entire story.^^

@Dylan-DPC
Copy link
Member

@bors try

@oli-obk oli-obk closed this Mar 25, 2022
@oli-obk oli-obk reopened this Mar 25, 2022
@matthiaskrgr
Copy link
Member

@bors r=RalfJung p=1

@bors
Copy link
Contributor

bors commented Mar 25, 2022

📌 Commit 189409b has been approved by RalfJung

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 25, 2022
@bors
Copy link
Contributor

bors commented Mar 25, 2022

⌛ Testing commit 189409b with merge 3fe3b89...

@bors
Copy link
Contributor

bors commented Mar 25, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 3fe3b89 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 25, 2022
@bors bors merged commit 3fe3b89 into rust-lang:master Mar 25, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 25, 2022
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #95282!

Tested on commit 3fe3b89.
Direct link to PR: #95282

🎉 miri on windows: test-fail → test-pass (cc @RalfJung @oli-obk @eddyb).
🎉 miri on linux: test-fail → test-pass (cc @RalfJung @oli-obk @eddyb).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Mar 25, 2022
@rust-highfive
📣 Toolstate changed by rust-lang/rust#95282!
e074848 
Tested on commit rust-lang/rust@3fe3b89.
Direct link to PR: <rust-lang/rust#95282>

🎉 miri on windows: test-fail → test-pass (cc @RalfJung @oli-obk @eddyb).
🎉 miri on linux: test-fail → test-pass (cc @RalfJung @oli-obk @eddyb).
@RalfJung RalfJung deleted the miri branch March 26, 2022 14:05
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3fe3b89): comparison url.

Summary: This benchmark run did not return any relevant results. 6 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#95250
8 participants
@RalfJung @Dylan-DPC @matthiaskrgr @bors @rust-highfive @rust-timer @oli-obk @rustbot