Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Miri #94716

Merged
merged 1 commit into from
Mar 8, 2022
Merged

update Miri #94716

merged 1 commit into from
Mar 8, 2022

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Mar 8, 2022

Fixes #94687
r? @rust-lang/miri

@rust-highfive
Copy link
Collaborator

Some changes occured to the Miri submodule

cc @rust-lang/miri

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 8, 2022
@RalfJung
Copy link
Member Author

RalfJung commented Mar 8, 2022

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Mar 8, 2022

📌 Commit 5756239 has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2022
@Dylan-DPC
Copy link
Member

can r+ if needed, unless you want a detalied review

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 8, 2022
@matthiaskrgr
Rollup merge of rust-lang#94716 - RalfJung:miri, r=RalfJung
de31dcf 
update Miri

Fixes rust-lang#94687
r? `@rust-lang/miri`
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 8, 2022
Closed
@RalfJung
Copy link
Member Author

RalfJung commented Mar 8, 2022

Thanks! We usually self-r+ tool updates, at least for Miri. I thought by putting in r? @rust-lang/miri I could prevent it from annoying others unnecessarily but highfive didn't play along...

@Dylan-DPC
Copy link
Member

no worries :)

@RalfJung
Copy link
Member Author

RalfJung commented Mar 8, 2022 •
edited
Loading

@bors r- (PR CI failed)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 8, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@RalfJung
Copy link
Member Author

RalfJung commented Mar 8, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Mar 8, 2022

📌 Commit 16b4084 has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 8, 2022
@bors
Copy link
Contributor

bors commented Mar 8, 2022

⌛ Testing commit 16b4084 with merge d2710db...

@bors
Copy link
Contributor

bors commented Mar 8, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing d2710db to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 8, 2022
@bors bors merged commit d2710db into rust-lang:master Mar 8, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 8, 2022
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #94716!

Tested on commit d2710db.
Direct link to PR: #94716

🎉 miri on windows: build-fail → test-pass (cc @oli-obk @eddyb @RalfJung).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk @eddyb @RalfJung).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Mar 8, 2022
@rust-highfive
📣 Toolstate changed by rust-lang/rust#94716!
06dc678 
Tested on commit rust-lang/rust@d2710db.
Direct link to PR: <rust-lang/rust#94716>

🎉 miri on windows: build-fail → test-pass (cc @oli-obk @eddyb @RalfJung).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk @eddyb @RalfJung).
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d2710db): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@RalfJung RalfJung deleted the miri branch March 8, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#94597
8 participants
@RalfJung @rust-highfive @bors @Dylan-DPC @rust-log-analyzer @rust-timer @Mark-Simulacrum @rustbot