Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debuginfo: Support fat pointers to unsized tuples. #94050

Merged
merged 1 commit into from
Feb 19, 2022
Merged

debuginfo: Support fat pointers to unsized tuples. #94050

merged 1 commit into from
Feb 19, 2022

Conversation

michaelwoerister
Copy link
Member

This PR makes fat pointer debuginfo generation handle the case of unsized tuples.

Fixes #93871

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 16, 2022
@rust-highfive
Copy link
Collaborator

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 16, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@lcnr
Copy link
Contributor

lcnr commented Feb 16, 2022

r? @wesleywiser

@rust-highfive rust-highfive assigned wesleywiser and unassigned lcnr Feb 16, 2022
@michaelwoerister michaelwoerister force-pushed the fix-unsized-tuple-debuginfo branch from 923d2a2 to 28ca6b0 Compare February 16, 2022 12:29
@michaelwoerister
Copy link
Member Author

This will hopefully also fix building core with debuginfo=2: #93866

@bors p=1 since it fixes a regression that might end up in beta otherwise.

@pnkfelix
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Feb 17, 2022

📌 Commit 28ca6b0 has been approved by pnkfelix

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 17, 2022
@bors
Copy link
Contributor

bors commented Feb 17, 2022

⌛ Testing commit 28ca6b0 with merge 7e015b34efec1723f919f107230c63e9dd619192...

@bors
Copy link
Contributor

bors commented Feb 17, 2022

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 17, 2022
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@matthiaskrgr
Copy link
Member

@bors retry auto (dist-armhf-linux, ubuntu-20.04-xl) timeout

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 17, 2022
@bors
Copy link
Contributor

bors commented Feb 18, 2022

⌛ Testing commit 28ca6b0 with merge 1a226156777dac93dd30ef6162fbc95244ccbd65...

@bors
Copy link
Contributor

bors commented Feb 18, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 18, 2022
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@michaelwoerister
Copy link
Member Author

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2022
@bors
Copy link
Contributor

bors commented Feb 18, 2022

⌛ Testing commit 28ca6b0 with merge 3136b7918e16c0606807fd4f5917875dd737b58d...

@bors
Copy link
Contributor

bors commented Feb 18, 2022

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 18, 2022
@matthiaskrgr
Copy link
Member

@bors retry auto (i686-gnu-nopt, ubuntu-20.04-xl) timeout

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2022
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@matthiaskrgr
Copy link
Member

@bors p=20 makes sure this gets in before the beta cutoff

@bors
Copy link
Contributor

bors commented Feb 18, 2022

⌛ Testing commit 28ca6b0 with merge 5a1a370...

@bors
Copy link
Contributor

bors commented Feb 19, 2022

☀️ Test successful - checks-actions
Approved by: pnkfelix
Pushing 5a1a370 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 19, 2022
@bors bors merged commit 5a1a370 into rust-lang:master Feb 19, 2022
@rustbot rustbot added this to the 1.60.0 milestone Feb 19, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5a1a370): comparison url.

Summary: This benchmark run did not return any relevant results. 1 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wesleywiser wesleywiser

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.60.0
Development

Successfully merging this pull request may close these issues.

ICE: unsized_tuple_coercion with debuginfo=2
10 participants
@michaelwoerister @rust-highfive @rust-log-analyzer @lcnr @pnkfelix @bors @matthiaskrgr @rust-timer @wesleywiser @rustbot