-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Box drop through Drop trait #93105
Conversation
r? @m-ou-se (rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
763eba2
to
6059879
Compare
The job Click to see the possible cause of the failure (guessed by this bot)
|
Alright good, now that CI is failing in the way it should, all we have to do is wait for #93028 to merge. |
I suspect this will run into problems with ensuring that the memory is indeed freed in case of incomplete initialization as part of the Would be a good idea to verify there are tests for these behaviours and if not – to implement some. |
Actually, this is still going to need some compiler magic for dropping T because of some of Box's other magic. |
Honestly, don't think this is that useful because of that. Not gonna bother finishing this. |
This PR makes Box drop through its implementation of the Drop trait, instead of by being special-cased in the compiler.
Blocked on #93028