Rewrote extra::getopts to use methods #9267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| target: opt_str2(getopts::opt_maybe_str(matches, "target")).to_str(), | ||
| adb_path: opt_str2(getopts::opt_maybe_str(matches, "adb-path")).to_str(), | ||
| matches.opt_maybe_str("ratchet-noise-percent").map_move(|s| | ||
| f64::from_str(s).unwrap()), |
There was a problem hiding this comment.
f64::from_str is disappearing in #9275, so if this could change to from_str(s).unwrap() it'd save at least one rebase. (Also, this could be .and_then(from_str) right?)
There was a problem hiding this comment.
Changed it to and_then, re-testing right now. Any other lines like this?
|
Don't r+ yet, still rewriting a few things in the documentation Ready now. |
| use std::vec; | ||
|
|
||
| /// Name of an option. Either an string or a single char. |
There was a problem hiding this comment.
In "Either an string", s/an/a.
|
Hm, the failure doesn't seem related to my changes. |
Some minor api and doc adjustments
bors
added a commit
that referenced
this pull request
Sep 19, 2013
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 6, 2022
Fix sorting in ` cargo dev update_lints` script changelog: none The old code cloned and sorted `usable_lints` into `sorted_usable_lints`, but then failed to do anything with `sorted_usable_lints`. This was discovered by my new `collection_is_never_read` lint (rust-lang#9267) that I'm working on! Fix: I renamed the sorted vector to `usable_lints`. Therefore it now gets used where the unsorted one was used previously.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Mar 10, 2023
…llogiq Add `collection_is_never_read` Fixes rust-lang#9267 `@flip1995` and `@llogiq,` I talked with you about this one at Rust Nation in London last week. :-) This is my first contribution to Clippy, so lots of feedback would be greatly appreciated. - \[ ] Followed [lint naming conventions][lint_naming] - \[x] Added passing UI tests (including committed `.stderr` file) - \[x] `cargo test` passes locally - \[x] Executed `cargo dev update_lints` - \[x] Added lint documentation - \[x] Run `cargo dev fmt` `dogfood` found one true positive (see rust-lang#9509) and no false positives. `lintcheck` found no (true or false) positives, even when running on an extended set of crates. --- changelog: new lint [`collection_is_never_read`] [rust-lang#10415](rust-lang/rust-clippy#10415) <!-- changelog_checked -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.