-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kmc-solid: Add std::sys::solid::fs::File::read_buf
#92117
Conversation
r? @yaahc (rust-highfive has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (I'm not familiar with the Solid API but the call matches the read
impl so looks fine. The usage of ReadBuf lgtm).
Catching up with commit 3b263ce
e20e64a
to
874514c
Compare
Thanks! @bors r+ |
📌 Commit 874514c has been approved by |
⌛ Testing commit 874514c with merge c60cc9aeca09a5b201184e65deeb9c813daa32d1... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
@bors retry Windows test_interior_nul issue |
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#88858 (Allow reverse iteration of lowercase'd/uppercase'd chars) - rust-lang#91544 (Fix duplicate derive clone suggestion) - rust-lang#92026 (Add some JSDoc comments to rustdoc JS) - rust-lang#92117 (kmc-solid: Add `std::sys::solid::fs::File::read_buf`) - rust-lang#92139 (Change Backtrace::enabled atomic from SeqCst to Relaxed) - rust-lang#92146 (Don't emit shared files when scraping examples from dependencies in Rustdoc) - rust-lang#92208 (Quote bat script command line) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This PR adds
std::sys::solid::fs::File::read_buf
to catch up with the changes introduced by #81156 and fix the*-kmc-solid_*
Tier 3 targets..