-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change AdtDef's PartialEq
and Hash
impls to use DefId
#92040
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 4233b73 with merge 459ffcf2c335b383b9459fd457201770509d8c73... |
☀️ Try build successful - checks-actions |
Queued 459ffcf2c335b383b9459fd457201770509d8c73 with parent 2595d03, future comparison URL. |
Note that due to merging rust-lang/rustc-perf#1123, these runs may look quite bad -- once we get another master commit landed + benchmarked, re-running perf should make any noise there go away. It shouldn't affect non-incremental results, though, of course. (Leaving this comment on all pending perf run PRs). |
Finished benchmarking commit (459ffcf2c335b383b9459fd457201770509d8c73): comparison url. Summary: This change led to very large relevant mixed results 🤷 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never |
Re-running to get accurate incremental perf results: @bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 4233b73 with merge df6895368ef88ce97b479cd8c8bbaaa94cad07df... |
☀️ Try build successful - checks-actions |
Queued df6895368ef88ce97b479cd8c8bbaaa94cad07df with parent d3f3004, future comparison URL. |
Finished benchmarking commit (df6895368ef88ce97b479cd8c8bbaaa94cad07df): comparison url. Summary: This change led to moderate relevant regressions 😿 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never |
Merged as part of #91924 |
No description provided.