When declaring extern fns from external crates, use the correct abi #9196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ty::ty_bare_fn(_) | ty::ty_closure(_) => { | ||
| ty::ty_bare_fn(ref fn_ty) => { | ||
| let cconv = foreign::llvm_calling_convention(ccx, fn_ty.abis); | ||
| let cconv = cconv.unwrap_or_default(lib::llvm::CCallConv); |
There was a problem hiding this comment.
This should now be .unwrap_or(lib::llvm::CCallConv).
|
@alexcrichton: nope - really no way to add a test unless we add something like a You could write a Windows-only test with |
Beforehand it was assumed that the standard cdecl abi was used for all extern fns of extern crates, but this reads the abi of the extern fn type and declares the function in the local crate with the appropriate type.
bors
added a commit
that referenced
this pull request
Sep 16, 2013
Beforehand it was assumed that the standard cdecl abi was used for all extern fns of extern crates, but this reads the abi of the extern fn type and declares the function in the local crate with the appropriate type. I was trying to think of how to write a test for this, but I was just drawing up blanks :(. Are there standard functions in libc which are not of the cdecl abi? If so we could try linking to them and make sure that the cal completes successfully. Otherwise, I manually verified that the function was declared correctly by looking at the llvm assembly. cc #9055 (I'm not sure if this will fix that issue)
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 18, 2022
Fix example for `clippy::invalid_regex` Close rust-lang#9194 changelog: previous example doesn't trigger lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beforehand it was assumed that the standard cdecl abi was used for all extern
fns of extern crates, but this reads the abi of the extern fn type and declares
the function in the local crate with the appropriate type.
I was trying to think of how to write a test for this, but I was just drawing up blanks :(. Are there standard functions in libc which are not of the cdecl abi? If so we could try linking to them and make sure that the cal completes successfully.
Otherwise, I manually verified that the function was declared correctly by looking at the llvm assembly.
cc #9055 (I'm not sure if this will fix that issue)