Prepare to enable tests on Android #9121
Conversation
| ifeq ($(OSTYPE_$(1)), linux-androideabi) | ||
| $$(LIBUV_MAKEFILE_$(1)_$(2)): $$(LIBUV_DEPS) | ||
| (cd $(S)src/libuv/ && \ | ||
| $$(CFG_PYTHON) ./gyp_uv -f make -Dtarget_arch=$$(LIBUV_ARCH_$(1)) -D ninja -DOS=android \ |
There was a problem hiding this comment.
Is there already a makefile variable for OS=android somewhere? I'd love to reduce the amount of duplication among platforms (that's what gyp is supposed to take care of)
There was a problem hiding this comment.
I don't know. Also I am not sure whether that will help, since Rust and libuv may have different ideas about what the name of an OS should be.
There was a problem hiding this comment.
Hmm that does appear to be the case, that's unfortunate, but could this be a separate define?
Something like
ifeq ($(OSTYPE_$(1)), linux-androideabi)
LIBUV_OS_$(1) = -DOS=android
else
LIBUV_OS_$(1) =
endif
and then you use LIBUV_OS_$(1) in the same rule.
|
Re-purposed LIBUV_OSTYPE (which was unused) to pass OS to gyp_uv. Also un-xfail a test since #9117 is fixed. |
|
You mentioned that you un-xfail'd a test, but there doesn't appear to be any tests that were un-xfail'd? Looks like one was xfail'd, though... |
|
Before the last update, two tests were xfailed, now only one test is xfailed. (Un-xfailed one is capture_nil.) |
Ignore failing tests on Android to prepare for #9120.
…, r=flip1995 Fix stderr for cast_size_32bit changelog: fix stderr for cast_size_32bit
Ignore failing tests on Android to prepare for #9120.