Set color for <a> in a more straightforward way. #91102
Conversation
|
Some changes occurred in HTML/CSS/JS. |
|
It changes a few things:
Can you also provide a doc with usage of the "jump to def" feature? I think it'll change their color as well. And finally: please add GUI tests for the two cases above and for links more generally. ;) |
This makes it easier to find the test that needs fixing.
|
Here's a doc with the jump to def feature: https://rustdoc.crud.net/jsha/theme-anchor-rustls/src/rustls/cipher.rs.html#8-12. You were right, the links in the source view had the wrong color. I fixed that. I also made a small tweak to the rustdoc-gui tester, so it would print full filenames on error. That's something I've run into trouble with before; it's not always clear what needs fixing, particularly when I was new on the project. |
This comment has been minimized.
This comment has been minimized.
| @@ -0,0 +1,12 @@ | |||
| goto: file://|DOC_PATH|/test_docs/struct.HeavilyDocumentedStruct.html | |||
|
|
|||
There was a problem hiding this comment.
Better enforce the theme used (I had some issues because my default theme isn't the light one). To do it, take a look here.
Then it's a good idea, thanks! |
Previously, we set the default color for <a> tags to black, and then had an override with a bunch of not() clauses to set anchors in docblocks to blue. Instead, we should set the default color for <a> to blue (or equivalent in other themes), and override it for places like the sidebar or search results, where we don't want them to be styled as links.
|
Thanks! r=me once CI pass. |
|
@bors r=GuillaumeGomez rollup |
|
📌 Commit a56559d has been approved by |
…askrgr Rollup of 3 pull requests Successful merges: - rust-lang#91102 (Set color for <a> in a more straightforward way.) - rust-lang#91143 (Update books) - rust-lang#91144 (Update cargo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Previously, we set the default color for tags to black, and then had an override with a bunch of not() clauses to set anchors in
docblocks to blue.
Instead, we should set the default color for to blue (or equivalent in other themes), and override it for places like the sidebar or search results, where we don't want them to be styled as links.
Demo at https://rustdoc.crud.net/jsha/theme-anchor/std/string/struct.String.html. This should result in no visible changes.
r? @GuillaumeGomez