Update Clippy dependencies without patch versions #88517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in src/tools/clippy. cc @rust-lang/clippy |
|
(rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
|
This will add additional versions for cargo_metadata and compiletest_rs. |
ad0f5e7 to
e0cc357
Compare
Is that an impediment? |
|
There is some movement to keep number of (duplicated) dependencies as low as possible, in other case we always can do For |
flip1995
reviewed
Aug 31, 2021
| tar = "0.4" | ||
| toml = "0.5" | ||
| ureq = "2.2" | ||
| walkdir = "2.3" |
There was a problem hiding this comment.
This removes clap and adds walkdir?
There was a problem hiding this comment.
Removal of clap was me fat-fingering the patch by hand.
walkdir was added here: rust-lang/rust-clippy@997ddbb
This version of clippy does yet not seem to include that commit.
Both problems were fixed with my most recent push.
Cargo.lock
Outdated
| @@ -429,6 +447,19 @@ dependencies = [ | |||
| "serde_json", | |||
| ] | |||
|
|
|||
| [[package]] | |||
| name = "cargo_metadata" | |||
There was a problem hiding this comment.
We'll probably have to do a coordinated dep update for cargo_metadata and compiletest_rs.
There was a problem hiding this comment.
Old version for cargo_metadata (with bunch of other stuff) can be dropped when rustfmt will be updated in rust repo (dependencies already updated in rustfmt repo).
There was a problem hiding this comment.
cargo_metadata in rustfmt seems to still use version 0.12 instead of 0.14. Is this intentional?
With rustfmt updated, we'd also need to update the tidy script and RLS.
There was a problem hiding this comment.
It was updated to 0.12 as it was most common version in workspace and required less changes, in case if it will updated to newer version.
|
Should I close #88515 and remove the "do not merge" status from this PR? Separately, all of this PR's changes, besides those to |
Yes.
I dunno. Updates should be evaluated one by one anyways so I probably wouldn't use a script. 🤷 |
Done.
From what I can tell, there is currently no Clippy "Dependabot," i.e., something to tell you when updates are possible. A script would at least provide this information, and one could always ignore the script's results. Anyway, it's here: https://gist.github.com/smoelius/02c63fa0aa33d1f2bc913c8008890d45 Please let me know if anything else is needed for this PR. |
That's because we also have to look out for the Rust repo a bit to not duplicate deps. To prevent duplicate deps, I suggest to keep |
This means that Also, Also, I interpreted your comment @flip1995 to mean |
flip1995
reviewed
Sep 1, 2021
There was a problem hiding this comment.
Some NITs I noticed.
To do the compiletest-rs update with MIRI, I suggest, that you open a PR against MIRI updating that dep. Once that gets merged you can do a submodule update for MIRI here in the Rust repo. To that submodule update, you can attach a commit updating the Clippy deps. In the last commit you can do the Cargo.lock update with cargo update -p miri -p clippy.
src/tools/clippy/Cargo.toml
Outdated
Comment on lines
24
to
26
| # begin automatic update | ||
| clippy_lints = { version = "0.1.50", path = "clippy_lints" } | ||
| clippy_lints = { version = "0.1", path = "clippy_lints" } | ||
| # end automatic update |
There was a problem hiding this comment.
Can you remove those comments, while you're at it. This is definitely not automatically updated 😄
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Sep 1, 2021
Update compiletest_rs dependency Hello. I am trying to [update some Clippy dependencies](rust-lang/rust#88517) in the rust repo. To help keep the overall number of dependencies down, I was asked to submit a PR here to update `compiletest_rs` to from `0.6.0` to `0.7.0`. I ran CI on my fork and the update didn't seem to cause any problems.
9b59957 to
082a301
Compare
I think this is done now. |
|
Regex update can be perf sensitive, plus 7 commits kinda a lot, squash a little. |
How many do you think would be appropriate? |
|
It looks like a few of the commits amend or reverse parts of the first commit so those can be squashed. |
082a301 to
6499c03
Compare
|
Better? |
|
Should I now request a review from a rust maintainer? |
cd4ea91 to
bd4b17a
Compare
|
Apologies. I think it's fixed now. |
flip1995
approved these changes
Sep 9, 2021
|
@bors r+ rollup=iffy (Cargo.lock update) |
|
📌 Commit bd4b17a has been approved by |
|
⌛ Testing commit bd4b17a with merge 516e2507557b628f68f7a5f20f49bcc8427c15d6... |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
|
I'm afraid the error doesn't mean much to me. |
|
@bors retry Windows image update has broken things. |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Sep 12, 2021
…flip1995 Update Clippy dependencies without patch versions Trial run for rust-lang/rust-clippy#7606
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (c6f32f3): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Sep 28, 2021
…ip1995 Update Clippy dependencies without patch versions Trial run for rust-lang/rust-clippy#7606
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trial run for rust-lang/rust-clippy#7606