tidy: verify that test revisions with --target have associated needs-llvm-components directives #86272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
90c56ea to
54d9fed
Compare
This comment has been minimized.
This comment has been minimized.
54d9fed to
25ae80e
Compare
This comment has been minimized.
This comment has been minimized.
25ae80e to
6c85ebb
Compare
This comment has been minimized.
This comment has been minimized.
6c85ebb to
cb94e25
Compare
This comment has been minimized.
This comment has been minimized.
cb94e25 to
76abcb6
Compare
|
r=me with nit fixed |
76abcb6 to
2eaaca3
Compare
Herein we verify that all of the tests that specify a `--target` compile-flag, are also annotated with the minimal set of required llvm components necessary to run that test.
Doesn't work though, because compiletest doesn't process ignores on a per-revision manner.
Otherwise something that ought to seemingly work like `//[x86] needs-llvm-components: x86` or `//[nll_beyond]should-fail` do not get evaluated properly.
2eaaca3 to
cfcb2b6
Compare
|
@bors r=Mark-Simulacrum
I had in my head some corner cases that I decided were nasty enough that this idea wouldn't work, but now I don't remember what they were. |
|
📌 Commit cfcb2b6 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that people who tend to write
--target#[no_core]tests don't miss specifying theneeds-llvm-componentsdirective. This is necessary for the test suite to pass when LLVM is compiled with a subset of components enabled.While here I also took the opportunity to implement a more fine-grained handling of the ignore directives, so that they are evaluated for each revision, rather than for the entire test. With this even if people have
armcomponent disabled, only the revision that depends on the arm component will not run.Fixes #82405