Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove obsolete -m64 option #86060

Closed
wants to merge 1 commit into from
Closed

remove obsolete -m64 option #86060

wants to merge 1 commit into from

Conversation

tschuett
Copy link

@tschuett tschuett commented Jun 6, 2021

Apple ld man page

 -m          Don't treat multiple definitions as an error.  This is no longer supported. This option is obsolete.

LLVM MachO lld: option is obsolete
https://github.com/llvm/llvm-project/blob/70804f2a2f7b87227a873cd6d8852ad295068e79/lld/MachO/Options.td#L1040

The LLVM lld is not going to implement -m64. It prevents bringing LLVM lld MachO support for rust.

see #85938

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matthewjasper (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 6, 2021
@tschuett tschuett closed this Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants